[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+FuTSdcXhdG_YRF5gU6xp_-a-zOEf6i_rtJVHUpCGBBTNKMHA@mail.gmail.com>
Date: Sat, 20 Apr 2013 22:34:09 -0400
From: Willem de Bruijn <willemb@...gle.com>
To: Richard Cochran <richardcochran@...il.com>
Cc: netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
Paul Chavent <paul.chavent@...ra.fr>,
daniel.borkmann@....ee.ethz.ch
Subject: Re: [PATCH net-next v2] packet: tx timestamping on tpacket ring
On Sat, Apr 20, 2013 at 12:43 PM, Richard Cochran
<richardcochran@...il.com> wrote:
> On Fri, Apr 19, 2013 at 05:51:57PM -0400, Willem de Bruijn wrote:
>
>> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
>> index 898cf5c..af9185d 100644
>> --- a/net/core/skbuff.c
>> +++ b/net/core/skbuff.c
>> @@ -3327,12 +3327,8 @@ void skb_tstamp_tx(struct sk_buff *orig_skb,
>> if (!sk)
>> return;
>>
>> - skb = skb_clone(orig_skb, GFP_ATOMIC);
>> - if (!skb)
>> - return;
>> -
>> if (hwtstamps) {
>> - *skb_hwtstamps(skb) =
>> + *skb_hwtstamps(orig_skb) =
>> *hwtstamps;
>
> And how does *hwtstamps get into the clone?
The struct is part of skb_shared_info, which is stored immediately
after skb->end in the region shared by all clones.
>
>> } else {
>> /*
>> @@ -3340,9 +3336,13 @@ void skb_tstamp_tx(struct sk_buff *orig_skb,
>> * so keep the shared tx_flags and only
>> * store software time stamp
>> */
>> - skb->tstamp = ktime_get_real();
>> + orig_skb->tstamp = ktime_get_real();
>> }
>>
>> + skb = skb_clone(orig_skb, GFP_ATOMIC);
>> + if (!skb)
>> + return;
>> +
>> serr = SKB_EXT_ERR(skb);
>> memset(serr, 0, sizeof(*serr));
>> serr->ee.ee_errno = ENOMSG;
>
> Thanks,
> Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists