[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f7afa813-42a7-4c3f-9059-52afaac4088b@email.android.com>
Date: Sun, 21 Apr 2013 22:43:19 +0200
From: Patrick McHardy <kaber@...sh.net>
To: David Miller <davem@...emloft.net>
CC: netdev@...r.kernel.org, amwang@...hat.com
Subject: Re: [PATCH 2/3] net: fix netdev features shift for features bit > 31
David Miller <davem@...emloft.net> schrieb:
>From: Patrick McHardy <kaber@...sh.net>
>Date: Sun, 21 Apr 2013 12:09:33 +0200
>
>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c: In function
>'qlcnic_set_netdev_features':
>>>> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:967:7: warning:
>large integer implicitly truncated to unsigned type [-Woverflow]
>>
>> This should be fixed by explicitly using 1ULL for the shifted value.
>>
>> Reported-by: kbuild test robot <fengguang.wu@...el.com>
>> Signed-off-by: Patrick McHardy <kaber@...sh.net>
>
>The limitation is in the variable being assigned to, not the value
>itself.
>
>The "1" is already cast to a netdev_features_t by the macro
>definition.
Right, I thought the warning was caused by the shift not being able to represent the result. I'll fix it up properly later.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists