netdev - Re: [Patch net-next v5 0/5] vxlan: add ipv6 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130422.160834.1941810644323096368.davem@davemloft.net>
Date:	Mon, 22 Apr 2013 16:08:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [Patch net-next v5 0/5] vxlan: add ipv6 support

This is broken.  Every time I see someone export new things from IPV6
and then try to use those symbols in some other unrelated module, it
is a huge red flag.

You can't call into IPV6 protected symbols unless VXLAN and IPV6 are
configured identically.

So with your changes, with VXLAN=y and IPV6=m, you'll get link errors.
I could see this just by looking at your patch, I didn't have to even
try to build it.

Please do not fix this by adding Kconfig dependencies, you have to
find another way.  In bonding and bridging, we've made it such that
you can configure them in any combination whatsoever with ipv6 and
everything works properly.  Most of them time this can be accomplished
by moving things into the explicit "obj-y" objects in
net/ipv6/Makefile

If you are adding stateful dependencies upon ipv6 (you want to inspect
the ipv6 routes or something like that), I'm sorry but I really don't
want any hard dependies on ipv6's internal state, we can't export that
properly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html