netdev - Re: you must fix this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnjE+r2DojykXaYC13MUJ9YxeiJwC0OnfS6rtPJU4uLwbO5nw@mail.gmail.com>
Date:	Mon, 22 Apr 2013 14:30:26 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: you must fix this

On Mon, Apr 22, 2013 at 1:23 PM, David Miller <davem@...emloft.net> wrote:
>
> You CANNOT call into functional ipv6 functions from unrelated
> kernel modules:
>
> net/built-in.o: In function `ip_tunnel_xmit':
> /home/davem/src/GIT/net-next/net/ipv4/ip_tunnel.c:619: undefined reference to `icmpv6_send'
>
This code is moved from ip_gre module to ip_tunnel in the restructuring
patch. So this dependency is carried from ip_gre module to ip_tunnel module.

> There is no way I can allow this, it requires a call into IPV6 proper
> to a function that cannot be added to one of the source files we
> force building statically into the kernel such as addrconf_core.c
>
> Right now things are completely broken with IPV6=y and everything
> else modular, and that is not acceptable.
>
> DO NOT fix this by adding Kconfig dependencies, and DO NOT fix this
> by mucking with ugly ifdefs the ip_tunnel.c
>
> You have to remove this need to call into a stateful portion of
> the IPV6 code, portions which cannot be moved into simply helper
> functions which get statically linked into the kernel.

ok. I will send fix for ip_tunnel.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html