netdev - Re: [PATCH 3/5 v2] net/cpsw: don't rely only on netif_running() to check which device is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51750587.5020801@ti.com>
Date:	Mon, 22 Apr 2013 15:10:23 +0530
From:	Mugunthan V N <mugunthanvnm@...com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC:	<netdev@...r.kernel.org>, <tglx@...utronix.de>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 3/5 v2] net/cpsw: don't rely only on netif_running() to
 check which device is active

On 4/22/2013 3:00 PM, Sebastian Andrzej Siewior wrote:
> On 04/22/2013 11:14 AM, Mugunthan V N wrote:
>>> How about this?
>> If this is the case, then other Ethernet drivers will also have the same
>> scenario,
>> if it can be fixed in a generic way then i will be good.
> Other ethernet drivers know if their device generated an interrupt,
> stop the source and schedule napi. But here it could be either the
> device or the slave device, right?
> After writing this, a better idea idea just bumped into my head.
>
> btw: Any update on http://www.spinics.net/lists/netdev/msg233296.html?
>
Yes, when interrupt is disabled in hardware then interrupt must be 
disabled in
my initial days i have verified it, CPSW doesn't allow any new interrupts to
propagate  to arm if CPSW interrupt is disabled but there is an issue. 
CPSW irq
signal is not directly connected to irq controller, it is connected via 
edge to
level conversion so if one interrupt reaches arm, irq controller has to be
disabled else arm get blocked in CPSW ISR.

Regards
Mugunthan V N
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html