netdev - [PATCH] Net: rxrpc: signed and unsigned issue, need type cast for n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <51750FC0.8000603@asianux.com>
Date:	Mon, 22 Apr 2013 18:24:00 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	David Miller <davem@...emloft.net>,
	"dhowells@...hat.com" <dhowells@...hat.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Serge Hallyn <serge.hallyn@...onical.com>
CC:	netdev <netdev@...r.kernel.org>
Subject: [PATCH] Net: rxrpc: signed and unsigned issue, need type cast for
 n_elem.


  n_elem is unsigned int which never < 0.
  but it seems, we realy need check it whether < 0.
  so need a type cast for it.

  find it by EXTRA_CFLAGS=-W


Signed-off-by: Chen Gang <gang.chen@...anux.com>
---
 net/rxrpc/ar-key.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/rxrpc/ar-key.c b/net/rxrpc/ar-key.c
index 7633a75..ba0b722 100644
--- a/net/rxrpc/ar-key.c
+++ b/net/rxrpc/ar-key.c
@@ -346,7 +346,7 @@ static int rxrpc_krb5_decode_tagged_array(struct krb5_tagged_data **_td,
 
 	n_elem = ntohl(*xdr++);
 	toklen -= 4;
-	if (n_elem < 0 || n_elem > max_n_elem)
+	if ((int)n_elem < 0 || n_elem > max_n_elem)
 		return -EINVAL;
 	*_n_elem = n_elem;
 	if (n_elem > 0) {
-- 
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html