lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 22 Apr 2013 15:30:03 +0200
From:	Florian Westphal <fw@...len.de>
To:	netdev@...r.kernel.org
Cc:	Florian Westphal <fw@...len.de>
Subject: [PATCH -next] net: avoid inet dependency on aes crypto

commit 798b2cbf9227b1bd7d37ae9af4d9c750e6f4de9c
(net: Add INET dependency on aes crypto for the sake of TCP fastopen.)
results in aes-asm module no longer being loaded when AES cipher is
requested, due to CRYPTO_AES=y.

However, there is no link-time dependency on aes. Drop dep and instead
set "default m" for aes crypto if inet is enabled.

Signed-off-by: Florian Westphal <fw@...len.de>
---
 crypto/Kconfig |    1 +
 net/Kconfig    |    1 -
 2 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 05c0ce5..151b3e0 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -584,6 +584,7 @@ comment "Ciphers"
 
 config CRYPTO_AES
 	tristate "AES cipher algorithms"
+	default m if INET
 	select CRYPTO_ALGAPI
 	help
 	  AES cipher algorithms (FIPS-197). AES uses the Rijndael
diff --git a/net/Kconfig b/net/Kconfig
index 1a22216..a1d2cab 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -62,7 +62,6 @@ source "net/iucv/Kconfig"
 config INET
 	bool "TCP/IP networking"
 	select CRYPTO
-	select CRYPTO_AES
 	---help---
 	  These are the protocols used on the Internet and on most local
 	  Ethernets. It is highly recommended to say Y here (this will enlarge
-- 
1.7.8.6

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists