netdev - Re: [PATCH net] e1000e: fix numeric overflow in phc settime method.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366653202.2037.2.camel@jtkirshe-mobl>
Date:	Mon, 22 Apr 2013 10:53:22 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Richard Cochran <richardcochran@...il.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Jeroen Van den Keybus <jeroen.vandenkeybus@...phase.com>,
	bruce.w.allan@...el.com, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH net] e1000e: fix numeric overflow in phc settime method.

On Mon, 2013-04-22 at 15:53 +0200, Richard Cochran wrote:
> 
> The PTP Hardware Clock settime function in the e1000e driver
> computes nanoseconds from a struct timespec. The code converts the
> seconds field .tv_sec by multiplying it with NSEC_PER_SEC. However,
> both operands are of type long, resulting in an unintended overflow.
> The patch fixes the issue by using the helper function from time.h.
> 
> Signed-off-by: Richard Cochran <richardcochran@...il.com>
> ---
>  drivers/net/ethernet/intel/e1000e/ptp.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-) 

Thanks Richard, I will add this to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)