netdev - Re: [PATCH net-next v3] rps: selective flow shedding during softnet overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366750009.8964.9.camel@edumazet-glaptop>
Date:	Tue, 23 Apr 2013 13:46:49 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Willem de Bruijn <willemb@...gle.com>
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net-next v3] rps: selective flow shedding during softnet
 overflow

On Tue, 2013-04-23 at 16:30 -0400, Willem de Bruijn wrote:
> On Tue, Apr 23, 2013 at 3:18 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:

> >> +write_unlock:
> >> +             synchronize_rcu();
> >
> > I believe you do not need this synchronize_rcu() call.
> 
> Because in this special case rcu_assign_pointer always replaces a
> NULL value, correct? Thanks again for the feedback! I rebased, reran
> the tests and will send v4 with these two changes (only).

Well, there is no assignment or freeing after the synchronize_rcu();

(mask is a local var only)

This looks as a leftover.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html