netdev - [PATCH net-next] net: remove redundant code in dev_hard_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366677094.16391.97.camel@edumazet-glaptop>
Date:	Mon, 22 Apr 2013 17:31:34 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	Krishna Kumar <krkumar2@...ibm.com>
Subject: [PATCH net-next] net: remove redundant code in dev_hard_start_xmit()

From: Eric Dumazet <edumazet@...gle.com>

This reverts commit 068a2de57ddf4f4 (net: release dst entry while
cache-hot for GSO case too)

Before GSO packet segmentation, we already take care of skb->dst if it
can be released.

There is no point adding extra test for every segment in the gso loop.

Signed-off-by: Eric Dumazet <edumazet@...gle.com>
Cc: Krishna Kumar <krkumar2@...ibm.com>
---
 net/core/dev.c |    7 -------
 1 file changed, 7 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 8a3cb2c..6a82eed 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2543,13 +2543,6 @@ gso:
 		skb->next = nskb->next;
 		nskb->next = NULL;
 
-		/*
-		 * If device doesn't need nskb->dst, release it right now while
-		 * its hot in this cpu cache
-		 */
-		if (dev->priv_flags & IFF_XMIT_DST_RELEASE)
-			skb_dst_drop(nskb);
-
 		if (!list_empty(&ptype_all))
 			dev_queue_xmit_nit(nskb, dev);
 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html