netdev - Re: [Patch net-next] ipv6: separate out procfs code from mcast.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130423.031805.544535198246859192.davem@davemloft.net>
Date:	Tue, 23 Apr 2013 03:18:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	amwang@...hat.com
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org
Subject: Re: [Patch net-next] ipv6: separate out procfs code from mcast.c

From: Cong Wang <amwang@...hat.com>
Date: Tue, 23 Apr 2013 15:15:02 +0800

> On Tue, 2013-04-23 at 03:11 -0400, David Miller wrote:
>> From: Cong Wang <amwang@...hat.com>
>> Date: Tue, 23 Apr 2013 15:07:00 +0800
>> 
>> > From: Cong Wang <amwang@...hat.com>
>> > 
>> > They well deserve a separated unit.
>> > 
>> > Cc: "David S. Miller" <davem@...emloft.net>
>> > Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org> 
>> > Signed-off-by: Cong Wang <amwang@...hat.com>
>> 
>> Cong, I'm not even reading these patches.
>> 
>> You're on this idea that you can just keep the sysfs and procfs bits
>> of ipv6 modular, and make the rest of ipv6 statically linked into the
>> kernel.
> 
> I am trying that only for mcast.c, not for the whole IPv6.

The multicast stuff does route lookups, how are you going to
accomplish this?

Besides you should move the statically-needed code into a new
file (mcast_core.c or something like that, following the existing
model and conventions for doing this) rather than the other way
around.

And that patch should be posted in a series with the user that
needs this (your vxlan ipv6 patches), not by itself.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html