netdev - Re: [PATCH net-next v2] netlink: fix compilation after memory mapped patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130424.142722.647145900485285061.davem@davemloft.net>
Date:	Wed, 24 Apr 2013 14:27:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	ebiederm@...ssion.com, netdev@...r.kernel.org, kaber@...sh.net,
	bhutchings@...arflare.com
Subject: Re: [PATCH net-next v2] netlink: fix compilation after memory
 mapped patches

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Wed, 24 Apr 2013 10:36:23 +0200

> Depending of the kernel configuration (CONFIG_UIDGID_STRICT_TYPE_CHECKS), we can
> get the following errors:
> 
> net/netlink/af_netlink.c: In function ‘netlink_queue_mmaped_skb’:
> net/netlink/af_netlink.c:663:14: error: incompatible types when assigning to type ‘__u32’ from type ‘kuid_t’
> net/netlink/af_netlink.c:664:14: error: incompatible types when assigning to type ‘__u32’ from type ‘kgid_t’
> net/netlink/af_netlink.c: In function ‘netlink_ring_set_copied’:
> net/netlink/af_netlink.c:693:14: error: incompatible types when assigning to type ‘__u32’ from type ‘kuid_t’
> net/netlink/af_netlink.c:694:14: error: incompatible types when assigning to type ‘__u32’ from type ‘kgid_t’
> 
> We must use the helpers to get the uid and gid, and also take care of user_ns.
> 
> Fix suggested by Eric W. Biederman <ebiederm@...ssion.com>.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied, thanks!