netdev - Re: [Patch net-next] ipv6: separate out procfs code from mcast.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366774181.3849.6.camel@cr0>
Date:	Wed, 24 Apr 2013 11:29:41 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	yoshfuji@...ux-ipv6.org
Subject: Re: [Patch net-next] ipv6: separate out procfs code from mcast.c

On Tue, 2013-04-23 at 14:33 +0200, Bjørn Mork wrote:
> Cong Wang <amwang@...hat.com> writes:
> 
> > On Tue, 2013-04-23 at 03:36 -0400, David Miller wrote:
> >> From: Cong Wang <amwang@...hat.com>
> >> Date: Tue, 23 Apr 2013 15:30:20 +0800
> >> 
> >> > This is hard to do, as in the email I replied to Stephen. So I
> >> > prefer to just add a Kconfig dependency, at least for now.
> >> 
> >> A Kconfig hack is exactly what I've told you is an unacceptable
> >> solution.
> >
> > Please enlighten me for a third solution. :)
> 
> This is an completely untested idea....
> 
> I note that vxlan_init_net requires a successful sock_create_kern().
> That implies a request_module("net-pf-...") followed by try_module_get.
> 
> So if the sock_create_kern(PF_INET6, ..) succeeds then you *know* you
> have IPv6. If it fails with -EAFNOSUPPORT, then you could fall back to
> sock_create_kern(PF_INET, ..) and set a flag indicating that runtime
> IPv6 support is disabled.  Then use this flag to allow/deny configuring
> any IPv6 destinations.

Excellent point! You are certainly right. I will give it a try.

> 
> You may also have to protect the IPv6 modular symbols you use with
> symbol_request() or similar to prevent vxlan from depending on IPv6.  I
> dunno...
> 

This sounds a bit crazy.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html