netdev - Re: [PATCH 0/3] URGENT for 3.9: net: fec: revert NAPI introduction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366893854.4139.17.camel@weser.hi.pengutronix.de>
Date:	Thu, 25 Apr 2013 14:44:14 +0200
From:	Lucas Stach <l.stach@...gutronix.de>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, Frank.Li@...escale.com,
	shawn.guo@...aro.org, festevam@...il.com
Subject: Re: [PATCH 0/3] URGENT for 3.9: net: fec: revert NAPI introduction

Hi David,

Am Freitag, den 19.04.2013, 13:38 -0400 schrieb David Miller:
> From: Lucas Stach <l.stach@...gutronix.de>
> Date: Fri, 19 Apr 2013 16:36:01 +0200
> 
> > As it's way too late in the cycle to try and fix this up just revert the
> > relevant patches for now.
> 
> I disagree, fix this properly, the revert is more intrusive.

In the last days I've tried to fix the failures I'm seeing with adding
back the locks and disabling NAPI while restarting the controller. Both
approaches are neither minimally intrusive, nor do they fix all the
failures. I suspect there is a subtler error in some of the changed ring
buffer handling code also, but I wasn't able to track this down further
to a specific single-line change.

The only way to reliably fix all the failures I'm seeing is really
reverting the changes, as done with this series. So David please
consider taking the reverts, even while they are a bit intrusive, they
are the only way to get a 3.9 release out of the door with a working FEC
driver.

Regards,
Lucas
-- 
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html