netdev - Re: [PATCH net] sfc: Fix naming of MTD partitions for FPGA bitfiles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 25 Apr 2013 01:37:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com
Subject: Re: [PATCH net] sfc: Fix naming of MTD partitions for FPGA bitfiles

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 22 Apr 2013 22:40:07 +0100

> efx_mcdi_get_board_cfg() uses a buffer for the firmware response that
> is only large enough to hold subtypes for the originally defined set
> of NVRAM partitions.  Longer responses are truncated, and we may read
> off the end of the buffer when copying out subtypes for additional
> partitions.  In particular, this can result in the MTD partition for
> an FPGA bitfile being named e.g. 'eth5 sfc_fpga:00' when it should be
> 'eth5 sfc_fpga:01'.  This means the firmware update tool (sfupdate)
> can't tell which bitfile should be written to the partition.
> 
> Correct the response buffer size.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> ---
> This fix is required for full support of boards with PTP hardware
> clocks.  Please apply to net and queue it up for stable (only needed for
> 3.8.y and/or 3.9.y, depending on when this gets to Linus).

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html