netdev - Re: [PATCH] bonding: fix locking in enslave failure path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130425.040459.1780796133595305415.davem@davemloft.net>
Date:	Thu, 25 Apr 2013 04:04:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nikolay@...hat.com
Cc:	netdev@...r.kernel.org, andy@...yhouse.net, fubar@...ibm.com
Subject: Re: [PATCH] bonding: fix locking in enslave failure path

From: Nikolay Aleksandrov <nikolay@...hat.com>
Date: Mon, 22 Apr 2013 20:12:22 +0200

> In commit 3c5913b53fefc9d9e15a2d0f93042766658d9f3f ("bonding:
> primary_slave & curr_active_slave are not cleaned on enslave failure")
> I didn't account for the use of curr_active_slave without curr_slave_lock
> and since there are such users, we should hold bond->lock for writing while
> setting it to NULL (in the NULL case we don't need the curr_slave_lock).
> Keeping the bond lock as to avoid the extra release/acquire cycle.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...hat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html