netdev - Re: [PATCH v3] net: mac802154: comparision issue of type cast, finding by EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130425.041044.768895561908042668.davem@davemloft.net>
Date:	Thu, 25 Apr 2013 04:10:44 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	gang.chen@...anux.com
Cc:	sergei.shtylyov@...entembedded.com,
	alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com,
	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH v3] net: mac802154: comparision issue of type cast,
 finding by EXTRA_CFLAGS=-W

From: Chen Gang <gang.chen@...anux.com>
Date: Tue, 23 Apr 2013 19:24:36 +0800

> 
> Need change ~(u8)0 to 0xff, or in mac802154_wpan_xmit(), "u8 chan"
> will never == MAC802154_CHAN_NONE.
> 
> The related warning:
>   net/mac802154/wpan.c:325:2: warning: comparison is always false
>   due to limited range of data type [-Wtype-limits]
> 
> The related unit test:
>   cc -Wall -O2 -o test test.c
>   ./test
>   will output 'different'
> 
>   (after use '0xff' instead of '~(u8)0', it will output 'equal')
 ...
> Signed-off-by: Chen Gang <gang.chen@...anux.com>

This change belong in the 'net' tree, but your patch won't apply
cleanly there as this part of the header file looks slightly
different there.

Please respin your patch against 'net' and resubmit, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html