netdev - Re: [Patch net-next v2] bridge: do not expire mdb entry as long as bridge still uses it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130426125023.GA4812@gondor.apana.org.au>
Date:	Fri, 26 Apr 2013 20:50:23 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Cong Wang <amwang@...hat.com>
Cc:	netdev@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	"David S. Miller" <davem@...emloft.net>,
	Adam Baker <linux@...er-net.org.uk>
Subject: Re: [Patch net-next v2] bridge: do not expire mdb entry as long as
 bridge still uses it

On Thu, Apr 25, 2013 at 06:07:01PM +0800, Cong Wang wrote:
> On Thu, 2013-04-25 at 16:37 +0800, Herbert Xu wrote:
> > 
> > As you're saying the bridge interface's subscription is expiring
> > incorrectly, the question is why aren't we receiving those group
> > reports from ourselves, which should be sent out periodically if
> > we were subscribed to the group?
> 
> I thought IGMP report is optional as long as the multicast traffic is
> still running. If it is mandatory, I don't see any IGMP report sending
> out from guest, so the bug is in IPv4 multicast code rather than bridge
> code.
> 
> But this can't explain why guests can communicate with each other. :)

OK, if there is no querier in the network then our current default
behaviour is indeed broken because we won't get the reports needed
to sustain the subscriptions.

So we need to do two things:

1) Fix the group timeout mechanism to only arm the timer when a
corresponding query is received.
2) Resume sending queries when leave is received if the user makes
a querier.

Let me know if you'd like to work on this, otherwise I can take
a look at it next week.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html