netdev - Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130427090545.GY1366@pengutronix.de>
Date:	Sat, 27 Apr 2013 11:05:45 +0200
From:	Robert Schwebel <r.schwebel@...gutronix.de>
To:	David Miller <davem@...emloft.net>
Cc:	r.schwebel@...gutronix.de, lznuaa@...il.com,
	l.stach@...gutronix.de, netdev@...r.kernel.org,
	Frank.Li@...escale.com, festevam@...il.com, shawn.guo@...aro.org
Subject: Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable
 call"

On Fri, Apr 26, 2013 at 02:33:09PM -0400, David Miller wrote:
> From: Robert Schwebel <r.schwebel@...gutronix.de>
> Date: Fri, 26 Apr 2013 15:44:15 +0200
>
> > Seriously - it's friday, and 3.9 is expected to come out this
> > weekend.
>
> Seriously, it took you how long to notice the breakage and report
> it in sufficient detail for the author to make an attempt at a fix?
>
> I thnk Frank's request is reasonable given the circumstances, please
> work closely with him on the fix.

The FEC driver has worked fine in 3.8.x.

Frank's patches for the 3.9 cycle...

- remove locking in a way that memory is freed which is in use
- break the driver, up to a point where the kernel oopses when the link
  goes away
- mix up different changes (queue handling) and should have been split up
  into separate patches

Unfortunately, the breakage happens only on multicore (MX6Q) and if you
change the link status; that's probably the reason why it hasn't been
noticed earlier.

We have really tried to find a "quick fix which does it right", but it
has turned out that this isn't possible in such a short time, because it
is more complex than just re-adding locks. We feel that the results of
last week's activities are not good enough that they could be merged
without further breakage.

Please consider to merge the reverts. Otherwhise FEC will be broken in 3.9.

Of course, we can help with a real solution, but please after 3.9.final.

Thanks,
Robert
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html