netdev - Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHrpEqTE-oGcdMVk2LMffW0JWNgJ-b_+RakpCOVBy6WxA_ARGg@mail.gmail.com>
Date:	Sat, 27 Apr 2013 20:43:58 +0800
From:	Frank Li <lznuaa@...il.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	Robert Schwebel <r.schwebel@...gutronix.de>,
	David Miller <davem@...emloft.net>,
	Lucas Stach <l.stach@...gutronix.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Frank.Li@...escale.com" <Frank.Li@...escale.com>,
	Fabio Estevam <festevam@...il.com>,
	Shawn Guo <shawn.guo@...aro.org>
Subject: Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call"

2013/4/27, Francois Romieu <romieu@...zoreil.com>:
> Frank Li <lznuaa@...il.com> :
> [...]
>> diff --git a/drivers/net/ethernet/freescale/fec.c
>> b/drivers/net/ethernet/freescale/fe
>> index 73195f6..c945bb7 100644
>> --- a/drivers/net/ethernet/freescale/fec.c
>> +++ b/drivers/net/ethernet/freescale/fec.c
>> @@ -403,6 +403,11 @@ fec_restart(struct net_device *ndev, int duplex)
>>         const struct platform_device_id *id_entry =
>>                                 platform_get_device_id(fep->pdev);
>>         int i;
>> +       if (netif_running(ndev)) {
>> +               napi_disable(&fep->napi);
>
> napi_disable may sleep.
>
> fec_restart can be called with spinlock held in fec_enet_adjust_link

You are right. Spin lock in FEC enet adjust link can be removed when
remove spinlock in tx and RX.

>
> --
> Ueimor
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html