netdev - Re: [PATCH net-next] vxlan: restore source compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 26 Apr 2013 23:27:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	atzm@...atosphere.co.jp, netdev@...r.kernel.org,
	xiyou.wangcong@...il.com, dlstevens@...ibm.com,
	mike.rapoport@...ellosystems.com
Subject: Re: [PATCH net-next] vxlan: restore source compatibility

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Fri, 26 Apr 2013 16:54:44 -0700

> The commit:
>     vxlan: Allow setting destination to unicast address.

Please reference commits both by SHA1 ID and the commit header line text,
in this format:

	commit ${SHA1_ID} ("Commit header line text.")

> Broke source compatibility with exported user headers.
> Compile fails with older iproute2 source fails since IFLA_VXLAN_REMOTE not defined.

Judging by your patch, the problem is that IFLA_VXLAN_GROUP is not defined,
not IFLA_VXLAN_REMOTE.

Are the semantic change issues here as well?  Just wondering.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html