netdev - Re: [PATCH v2 1/2] tipc: tipc_bcbearer_send(): simplify bearer selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130429.154446.855221874054199436.davem@davemloft.net>
Date:	Mon, 29 Apr 2013 15:44:46 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	gerlando.falauto@...mile.com
Cc:	netdev@...r.kernel.org, jon.maloy@...csson.com,
	erik.hugne@...csson.com, ying.xue@...driver.com,
	holger.brunck@...mile.com
Subject: Re: [PATCH v2 1/2] tipc: tipc_bcbearer_send(): simplify bearer
 selection

From: Gerlando Falauto <gerlando.falauto@...mile.com>
Date: Mon, 29 Apr 2013 16:13:39 +0200

> Also some minor cosmetic improvements and comment style changes
> 
> Signed-off-by: Gerlando Falauto <gerlando.falauto@...mile.com>

You're mixing too many things, and actually adding style problems.

>  		struct tipc_bearer *p = bcbearer->bpairs[bp_index].primary;
> +		struct tipc_bearer *b = p;
>  		struct tipc_bearer *s = bcbearer->bpairs[bp_index].secondary;

Local variable declarations should be ordered from longest line
to shortest line.

> -		tipc_nmap_diff(&bcbearer->remains, &p->nodes, &bcbearer->remains_new);
> +		tipc_nmap_diff(&bcbearer->remains, &b->nodes,
> +			&bcbearer->remains_new);

This second line is indented incorrectly, do it like this:

	func(arg1, arg2,
	     arg3, arg4);

Specifically arg3 is aligned, using the appropriate mixture of TAB
and space characters, with the first column after the openning
parenthesis of the func() call.

>  		if (bcbearer->remains_new.count == bcbearer->remains.count)
> -			continue;	/* bearer pair doesn't add anything */
> +			continue;  /* Nothing added by bearer pair */

Why is two spaces better than a TAB, make it one space if you're going
to change this.

>  		if (bcbearer->remains_new.count == 0)
> -			break;	/* all targets reached */
> +			break;	/* All targets reached */

Untab this gap between break; and the comment into a space too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html