netdev - Re: [PATCH net-next 3/6] vxlan: fix byte order issues with NDA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130429164008.2515f886@nehalam.linuxnetplumber.net>
Date:	Mon, 29 Apr 2013 16:40:08 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	David Stevens <dlstevens@...ibm.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org
Subject: Re: [PATCH net-next 3/6] vxlan: fix byte order issues with NDA_PORT

On Mon, 29 Apr 2013 11:47:26 -0400
David Stevens <dlstevens@...ibm.com> wrote:

>         They were all in host order until your patch (though it looks like
> I may have used __be16 instead of __u32 and it "worked" despite the
> type error. I left it as 32 bits for netlink to be int-sized and not
> have unintended promotions, not to mention because "vxlan_port" is 32bit,
> and still is. I'm ok with switching them to network order and 16 bit,
> but I think you should make "vxlan_port" the same byte
> order and size as "remote_port" so the comparisons below don't require
> byte-swapping at run-time, as the original code did not.

Module parameters need to be host order, and there isn't really a good
way to type them as 16 bit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html