netdev - Re: [PATCH] sh_eth: use random MAC address if no valid one supplied

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <517E5CF7.4000600@cogentembedded.com>
Date:	Mon, 29 Apr 2013 15:43:51 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:	netdev@...r.kernel.org, nobuhiro.iwamatsu.yj@...esas.com,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH] sh_eth: use random MAC address if no valid one supplied

Hello.

On 29-04-2013 0:29, Laurent Pinchart wrote:

>> On Renesas R-Car based development boards, although a MAC address is printed
>> on all the Ethernet port labels, U-Boot  doesn't write a valid MAC address
>> to the Ether MAHR/MALR registers (there's no storage provided for the Ether
>> MAC address either), so we have to resort to using a random MAC address...

>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

>> ---
>> This patch is against the 'net-next.git' repository.

>>   drivers/net/ethernet/renesas/sh_eth.c |    5 +++++
>>   1 file changed, 5 insertions(+)

>> Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
>> ===================================================================
>> --- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
>> +++ net-next/drivers/net/ethernet/renesas/sh_eth.c
>> @@ -2735,6 +2735,11 @@ static int sh_eth_drv_probe(struct platf
>>
>>   	/* read and set MAC address */
>>   	read_mac_address(ndev, pd->mac_addr);
>> +	if (!is_valid_ether_addr(ndev->dev_addr)) {
>> +		dev_warn(&pdev->dev, "no valid MAC address supplied, using "
>> +			 "a random one.\n");

> Breaking log messages in the middle of a line is frowned upon, more than
> exceeding the 80 characters per line (soft) limit. I think

>          dev_warn(&pdev->dev,
>                   "no valid MAC address supplied, using a random one.\n");

> would be better.

    Thanks, totally forgot about that when doing a patch, only remembered 
after sending out.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html