netdev - Re: [PATCH net-next 1/2] vxlan: do not set SKB_GSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+ogi+PN9r-CfcsF_e7fQFK+h=8bkWruXqY6gKUtrCY8yg@mail.gmail.com>
Date:	Mon, 29 Apr 2013 09:35:58 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Dmitry Kravkov <dmitry@...adcom.com>
Cc:	eilong@...adcom.com, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] vxlan: do not set SKB_GSO_UDP

On Sun, Apr 28, 2013 at 11:16 AM, Dmitry Kravkov <dmitry@...adcom.com> wrote:
> Since SKB_GSO_* flags are set by appropriate gso_segment callback
> in TCP/UDP layer.
>
> CC: Pravin B Shelar <pshelar@...ira.com>
> Signed-off-by: Dmitry Kravkov <dmitry@...adcom.com>
> Signed-off-by: Eilon Greenstein <eilong@...adcom.com>
> ---

udp flag was set since we are using udp offload handler for vxlan gso.
But I think it forces to have udp offload for tunnel offloading.
Therefore the change looks right.

Acked-by: Pravin B Shelar <pshelar@...ira.com>

>  drivers/net/vxlan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index a7fd9a0..b92c6a0 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -913,7 +913,7 @@ static int handle_offloads(struct sk_buff *skb)
>                 if (unlikely(err))
>                         return err;
>
> -               skb_shinfo(skb)->gso_type |= (SKB_GSO_UDP_TUNNEL | SKB_GSO_UDP);
> +               skb_shinfo(skb)->gso_type |= SKB_GSO_UDP_TUNNEL;
>         } else if (skb->ip_summed != CHECKSUM_PARTIAL)
>                 skb->ip_summed = CHECKSUM_NONE;
>
> --
> 1.8.1.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html