netdev - Re: [PATCH net-next] net: Use consume_skb() to free gso segmented skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1367282022.8964.333.camel@edumazet-glaptop>
Date:	Mon, 29 Apr 2013 17:33:42 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Sridhar Samudrala <sri@...ibm.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: Use consume_skb() to free gso segmented
 skb

On Mon, 2013-04-29 at 16:02 -0700, Sridhar Samudrala wrote:
> Use consume_skb() to free the original skb that is successfully transmitted 
> as gso segmented skbs so that it is not treated as a drop due to an error.
> 
> Signed-off-by: Sridhar Samudrala <sri@...ibm.com>
> ---
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 7c30dce..4040673 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2565,8 +2565,11 @@ gso:
>  	} while (skb->next);
>  
>  out_kfree_gso_skb:
> -	if (likely(skb->next == NULL))
> +	if (likely(skb->next == NULL)) {
>  		skb->destructor = DEV_GSO_CB(skb)->destructor;
> +		consume_skb(skb);
> +		return rc;
> +	}
>  out_kfree_skb:
>  	kfree_skb(skb);
>  out:
> 

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html