netdev - Re: [PATCH 1/1 v2 net] net: fec: fix kernel oops when plug/unplug cable many times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130430.153528.689893142405978330.davem@davemloft.net>
Date:	Tue, 30 Apr 2013 15:35:28 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Frank.Li@...escale.com
Cc:	romieu@...zoreil.com, r.schwebel@...gutronix.de,
	l.stach@...gutronix.de, netdev@...r.kernel.org, festevam@...il.com,
	shawn.guo@...aro.org, lznuaa@...il.com
Subject: Re: [PATCH 1/1 v2 net] net: fec: fix kernel oops when plug/unplug
 cable many times

From: Frank Li <Frank.Li@...escale.com>
Date: Sun, 28 Apr 2013 11:08:28 +0800

> @@ -403,6 +403,12 @@ fec_restart(struct net_device *ndev, int duplex)
>  	const struct platform_device_id *id_entry =
>  				platform_get_device_id(fep->pdev);
>  	int i;
> +	if (netif_running(ndev)) {
> +		napi_disable(&fep->napi);
> +		netif_stop_queue(ndev);
> +		netif_tx_lock(ndev);
> +	}
> +
>  	u32 temp_mac[2];
>  	u32 rcntl = OPT_FRAME_SIZE | 0x04;
>  	u32 ecntl = 0x2; /* ETHEREN */

Please don't put real statements in the middle of function variable
declarations.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html