netdev - Re: [PATCH net 2/4] be2net: Fix ethtool get drvinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130430.155201.2039547623230450224.davem@davemloft.net>
Date:	Tue, 30 Apr 2013 15:52:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	somnath.kotur@...lex.com, netdev@...r.kernel.org,
	kalesh.purayil@...lex.com
Subject: Re: [PATCH net 2/4] be2net: Fix ethtool get drvinfo

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Tue, 30 Apr 2013 14:22:11 +0100

> On Tue, 2013-04-30 at 17:07 +0530, Somnath Kotur wrote:
>> From: Kalesh AP <kalesh.purayil@...lex.com>
>> 
>> Cannot issue any other mailbox command while firmware download is in progress.
>> The get_drvinfo ethtool hook can be invoked without acquiring any rtnl_lock.
> [...]
> 
> Although I documented that as being possible in ethtool.h, that was only
> because of one particular caller that has since been removed (commit
> e52ac3398c3d 'net: Use device model to get driver name in
> skb_gso_segment()').  So unless I missed another case, you could change
> the documentation.

Please address Ben's feedback and resubmit this series, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html