netdev - Re: [PATCH net-next] tg3: shows HW time stamping support only if ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130430131051.GA19993@obelix.rh>
Date:	Tue, 30 Apr 2013 10:10:51 -0300
From:	Flavio Leitner <fbl@...hat.com>
To:	Jiri Benc <jbenc@...hat.com>
Cc:	netdev <netdev@...r.kernel.org>,
	Nithin Nayak Sujir <nsujir@...adcom.com>,
	Michael Chan <mchan@...adcom.com>
Subject: Re: [PATCH net-next] tg3: shows HW time stamping support only if
 ptp_capable is present

On Tue, Apr 30, 2013 at 10:50:15AM +0200, Jiri Benc wrote:
> On Mon, 29 Apr 2013 14:08:07 -0300, Flavio Leitner wrote:
> > Current tg3 shows hardware timestamping support for all devices
> > when that is true only for the hardware with PTP_CAPABLE flag
> > present.
> > 
> > Signed-off-by: Flavio Leitner <fbl@...hat.com>
> > ---
> >  drivers/net/ethernet/broadcom/tg3.c | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> > index ac83c87..ef0b8a6 100644
> > --- a/drivers/net/ethernet/broadcom/tg3.c
> > +++ b/drivers/net/ethernet/broadcom/tg3.c
> > @@ -5992,10 +5992,13 @@ static int tg3_get_ts_info(struct net_device *dev, struct ethtool_ts_info *info)
> >  
> >  	info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
> >  				SOF_TIMESTAMPING_RX_SOFTWARE |
> > -				SOF_TIMESTAMPING_SOFTWARE    |
> > -				SOF_TIMESTAMPING_TX_HARDWARE |
> > -				SOF_TIMESTAMPING_RX_HARDWARE |
> > -				SOF_TIMESTAMPING_RAW_HARDWARE;
> > +				SOF_TIMESTAMPING_SOFTWARE;
> > +
> > +	if (tg3_flag(tp, PTP_CAPABLE)) {
> > +		info->so_timestamping = SOF_TIMESTAMPING_TX_HARDWARE |
>                                      ^^^^
>                          You need |= here.

Of course, I will send a follow up patch.
Thanks for reviewing it.
-- 
fbl
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html