netdev - Re: [PATCH v3 1/3] tipc: cosmetic: clean up comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5180C64C.2040805@keymile.com>
Date:	Wed, 01 May 2013 09:37:48 +0200
From:	Gerlando Falauto <gerlando.falauto@...mile.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"jon.maloy@...csson.com" <jon.maloy@...csson.com>,
	"erik.hugne@...csson.com" <erik.hugne@...csson.com>,
	"ying.xue@...driver.com" <ying.xue@...driver.com>,
	"Brunck, Holger" <Holger.Brunck@...mile.com>
Subject: Re: [PATCH v3 1/3] tipc: cosmetic: clean up comments

Hi Sergei,

On 04/30/2013 01:54 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 30-04-2013 11:33, Gerlando Falauto wrote:
>
>> Signed-off-by: Gerlando Falauto <gerlando.falauto@...mile.com>
>> ---
>> Changes from v2:
>> * Split cosmetic from functional changes
>
>>    net/tipc/bcast.c |   13 +++++++------
>>    1 file changed, 7 insertions(+), 6 deletions(-)
>
>> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
>> index 2655c9f..8438e01 100644
>> --- a/net/tipc/bcast.c
>> +++ b/net/tipc/bcast.c
>> @@ -584,8 +584,7 @@ static int tipc_bcbearer_send(struct sk_buff *buf,
>>    {
>>    	int bp_index;
>>
>> -	/*
>> -	 * Prepare broadcast link message for reliable transmission,
>> +	/* Prepare broadcast link message for reliable transmission,
>>    	 * if first time trying to send it;
>>    	 * preparation is skipped for broadcast link protocol messages
>>    	 * since they are sent in an unreliable manner and don't need it
>> @@ -613,11 +612,12 @@ static int tipc_bcbearer_send(struct sk_buff *buf,
>>    		struct tipc_bearer *s = bcbearer->bpairs[bp_index].secondary;
>>
>>    		if (!p)
>> -			break;	/* no more bearers to try */
>> +			break; /* No more bearers to try */
>>
>> -		tipc_nmap_diff(&bcbearer->remains, &p->nodes, &bcbearer->remains_new);
>> +		tipc_nmap_diff(&bcbearer->remains, &p->nodes,
>> +			       &bcbearer->remains_new);
>
>      It apeears you nopt only cleaning up comments in this patch but you don't
> mention this change in the changelog...

That's just adding a line break to split a long line.
Come on, seriously, is that *really* worth mentioning?
How about "tipc: cosmetic: clean up comments and break a long line"?

Thanks,
Gerlando
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html