netdev - Re: [IPROUTE PATCH v2] iproute2: act_ipt fix xtables breakage on older versions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51811D06.2070800@mojatatu.com>
Date:	Wed, 01 May 2013 09:47:50 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Alexander Duyck <alexander.h.duyck@...el.com>
CC:	shemminger@...tta.com, netdev@...r.kernel.org,
	jeffrey.t.kirsher@...el.com, Hasan Chowdhury <shemonc@...il.com>,
	Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [IPROUTE PATCH v2] iproute2: act_ipt fix xtables breakage on
 older versions.

Hi Alex,

On 13-04-30 12:07 PM, Alexander Duyck wrote:
> On 04/30/2013 05:59 AM, Jamal Hadi Salim wrote:


>
> In the git tree it is obvious that xtables_merge_options only takes 3
> parameters.  It is not until v1.4.11 which is XTABLES_VERSION_CODE == 6
> that we see xtables_merge_options take 4 parameters.
>

I apologize, you are correct. So whats incorporated now is wrong
but compiles fine on Debian.
So now i am wondering how the FSCK this thing even compiled.
I am going to test your patch on Debian squeeze, with iptables 1.4.8
(where the current code compiles just fine) and will ack it if all is
good

cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html