| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130501193412.GA32690@hmsreliant.think-freely.org> Date: Wed, 1 May 2013 15:34:12 -0400 From: Neil Horman <nhorman@...driver.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, bvanassche@....org Subject: Re: [PATCH RFC] netpoll: convert mutex into a semaphore On Wed, May 01, 2013 at 03:00:59PM -0400, David Miller wrote: > From: Neil Horman <nhorman@...driver.com> > Date: Tue, 30 Apr 2013 11:35:05 -0400 > > > Bart Van Assche recently reported a warning to me: > ... > > This resulted from my commit ca99ca14c which introduced a mutex_trylock > > operation in a path that could execute in interrupt context. When mutex > > debugging is enabled, the above warns the user when we are in fact > > exectuting in interrupt context > > interrupt context. > > > > After some discussion, It seems that a semaphore is the proper mechanism to use > > here. While mutexes are defined to be unusable in interrupt context, no such > > condition exists for semaphores (save for the fact that the non blocking api > > calls, like up and down_trylock must be used when in irq context). > > > > Signed-off-by: Neil Horman <nhorman@...driver.com> > > Reported-by: Bart Van Assche <bvanassche@....org> > > Neil this looks good to me so I'm going to toss it into my tree and queue > it up for -stable too, thanks! > Ok, cool deal. Thanks! Neil -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists