netdev - Re: [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in cpsw isr in particular sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130502.165227.1558171362372504606.davem@davemloft.net>
Date:	Thu, 02 May 2013 16:52:27 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	mugunthanvnm@...com
Cc:	netdev@...r.kernel.org, linux-omap@...r.kernel.org,
	bigeasy@...utronix.de
Subject: Re: [net-next PATCH 1/1] drivers: net: cpsw: irq not disabled in
 cpsw isr in particular sequence

From: Mugunthan V N <mugunthanvnm@...com>
Date: Thu, 2 May 2013 17:22:11 +0530

> In CPSW NAPI, after processing all interrupts IRQ is enabled and then book
> keeping irq_enabled is updated. In random cases when a packet is transmitted
> or received between processing packets and IRQ enabled, then just after
> enabled IRQ and before irq_enabled is updated, ISR is called so IRQs are
> not disabled as irq_enabled is still false and CPU gets locked in CPSW ISR.
> 
> By changing the sequence as update the irq_enabled and then enable IRQ
> fixes the issue. This issue is not captured always as it is a timing issue
> whether Tx or Rx IRQ is invoked between packet processing and enable IRQ.
> 
> Cc: Sebastian Siewior <bigeasy@...utronix.de>
> Signed-off-by: Mugunthan V N <mugunthanvnm@...com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html