lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 May 2013 18:19:51 +0100 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Francois Romieu <romieu@...zoreil.com> Cc: Tony Prisk <linux@...sktech.co.nz>, vt8500-wm8505-linux-kernel@...glegroups.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, davem@...emloft.net Subject: Re: [PATCHv3 3/3] net: velocity: Add platform device support to VIA velocity driver On Tue, Apr 30, 2013 at 01:04:50AM +0200, Francois Romieu wrote: > Tony Prisk <linux@...sktech.co.nz> : > [...] > > +static int velocity_remove(void *pdev, enum velocity_bus_type bustype) > > +{ > > + struct net_device *netdev; > > + struct velocity_info *vptr; > > + int pci = (bustype == BUS_PCI) ? 1 : 0; > > + > > + if (pci) > > + netdev = pci_get_drvdata(pdev); > > + else > > + netdev = platform_get_drvdata(pdev); > > The caller knows how to retrieve the net_device pointer, whence > the struct velocity_info pointer, whence any bustype dependent > function pointer to alleviate the "if (pci)" and CONFIG stuff. > > If you are not convinced, please consider turning the void * > into an union *. The other thing here is that you can just pass a struct device into these and retrieve the same driver data via: netdev = dev_get_drvdata(dev); as: static inline void *platform_get_drvdata(const struct platform_device *pdev) { return dev_get_drvdata(&pdev->dev); } static inline void *pci_get_drvdata(struct pci_dev *pdev) { return dev_get_drvdata(&pdev->dev); } So there's no need for void * or union nonsense. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists