netdev - Re: [PATCH] sky2: Fix crash on receiving VLAN frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130503075916.21a59491@nehalam.linuxnetplumber.net>
Date:	Fri, 3 May 2013 07:59:16 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Kirill Smelkov <kirr@....spb.ru>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Patrick McHardy <kaber@...sh.net>,
	Mirko Lindner <mlindner@...vell.com>
Subject: Re: [PATCH] sky2: Fix crash on receiving VLAN frames

On Fri,  3 May 2013 18:22:04 +0400
Kirill Smelkov <kirr@....spb.ru> wrote:

> Stephen, I wonder, why copy_skb_header() is not used in
> sky2.c::receive_copy() ? Problems, where receive_copy was updated field
> by field showed several times already, e.g.

The drive pre-dates copy_skb_header.
Why not convert driver to use it and avoid this and related problems?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html