netdev - Re: [PATCH net] bridge: fix race with topology change timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130503.161137.1979947914410869390.davem@davemloft.net>
Date:	Fri, 03 May 2013 16:11:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] bridge: fix race with topology change timer

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Thu, 2 May 2013 17:23:28 -0700

> A bridge should only send topology change notice if it is not
> the root bridge. It is possible for message age timer to elect itself
> as a new root bridge, and still have a topology change timer running
> but waiting for bridge lock on other CPU.
> 
> Solve the race by checking if we are root bridge before continuing.
> This was the root cause of the cases where br_send_tcn_bpdu would OOPS.
> 
> Reported-by: JerryKang <jerry.kang@...sung.com>
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

Applied and queued up for -stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html