netdev - Re: [PATCH] sky2: Fix crash on receiving VLAN frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 03 May 2013 16:13:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kirr@....spb.ru
Cc:	netdev@...r.kernel.org, kaber@...sh.net,
	stephen@...workplumber.org, mlindner@...vell.com
Subject: Re: [PATCH] sky2: Fix crash on receiving VLAN frames

From: Kirill Smelkov <kirr@....spb.ru>
Date: Fri,  3 May 2013 18:22:04 +0400

> After recent 86a9bad3 (net: vlan: add protocol argument to packet
> tagging functions) my sky2 started to crash on receive of tagged
> frames, with backtrace similar to
 ...
> Fix it.
> 
> P.S.
> 
> Stephen, I wonder, why copy_skb_header() is not used in
> sky2.c::receive_copy() ? Problems, where receive_copy was updated field
> by field showed several times already, e.g.
> 
>     3f42941b    (sky2: propogate rx hash when packet is copied)
>     e072b3fa    (sky2: fix receive length error in mixed non-VLAN/VLAN traffic)
> 
> Cc: Patrick McHardy <kaber@...sh.net>
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Cc: Mirko Lindner <mlindner@...vell.com>
> Signed-off-by: Kirill Smelkov <kirr@....spb.ru>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html