lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 04 May 2013 07:17:32 +1000 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: Ben Hutchings <bhutchings@...arflare.com> Cc: netdev@...r.kernel.org, David Miller <davem@...emloft.net>, linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>, David Gibson <dwg@....ibm.com> Subject: Re: net/eth/ibmveth: Fixup retrieval of MAC address On Fri, 2013-05-03 at 17:30 +0100, Ben Hutchings wrote: > > + /* Workaround for old/broken pHyp */ > > + if (mac_len == 8) > > + mac_addr_p += 2; > > + if (mac_len != 6) { > > Missing 'else' before the second if? Absolutely... oops :-) I couldn't find a version of pHyp with the wrong property to test with. I suppose I could hack it up in OFW before boot. I'll fix that and respin, sorry about that. Cheers, Ben. > > + dev_err(&dev->dev, "VETH_MAC_ADDR attribute wrong len %d\n", > > + mac_len); > > + return -EINVAL; > > + } > [...] > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists