netdev - Re: [PATCH net-next] gre: Fix GREv4 TCPv6 segmentation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1367550055.29805.14.camel@edumazet-glaptop>
Date:	Thu, 02 May 2013 20:00:55 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Pravin B Shelar <pshelar@...ira.com>
Cc:	netdev@...r.kernel.org, sesse@...gle.com
Subject: Re: [PATCH net-next] gre: Fix GREv4 TCPv6 segmentation.

On Thu, 2013-05-02 at 19:14 -0700, Pravin B Shelar wrote:
> For ipv6 traffic, GRE can generate packet with strange GSO
> bits, e.g. ipv4 packet with SKB_GSO_TCPV6 flag set.  Therefore
> following patch relaxes check in inet gso handler to allow
> such packet for segmentation.
> This patch also fixes wrong skb->protocol set that was done in
> gre_gso_segment() handler.
> 
> Reported-by: Steinar H. Gunderson <sesse@...gle.com>
> CC: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
> ---
> Same issue exist in 3.8.
> ---

Thanks a lot.

I did a quick test and it appears to fix the problem.

Acked-by: Eric Dumazet <edumazet@...gle.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html