lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 5 May 2013 20:30:21 +0200 From: Florian Westphal <fw@...len.de> To: Konstantin Khlebnikov <khlebnikov@...nvz.org> Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, Florian Westphal <fw@...len.de>, linux-kernel@...r.kernel.org, Jesper Dangaard Brouer <brouer@...hat.com> Subject: Re: [PATCH] net: frag, fix race conditions in LRU list maintenance Konstantin Khlebnikov <khlebnikov@...nvz.org> wrote: > This patch fixes race between inet_frag_lru_move() and inet_frag_lru_add() > which was introduced in commit 3ef0eb0db4bf92c6d2510fe5c4dc51852746f206 > ("net: frag, move LRU list maintenance outside of rwlock") > > One cpu already added new fragment queue into hash but not into LRU. > Other cpu found it in hash and tries to move it to the end of LRU. > This leads to NULL pointer dereference inside of list_move_tail(). > > Another possible race condition is between inet_frag_lru_move() and > inet_frag_lru_del(): move can happens after deletion. True, thanks for fixing this problem. > This patch initializes LRU list head before adding fragment into hash and > inet_frag_lru_move() doesn't touches it if it's empty. Acked-by: Florian Westphal <fw@...len.de> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists