netdev - Re: PATCH iproute2] catch iptables interface changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130506165343.GA9077@localhost>
Date:	Mon, 6 May 2013 18:53:43 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	shemminger@...tta.com,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Jan Engelhardt <jengelh@...i.de>
Subject: Re: PATCH iproute2] catch iptables interface changes

On Sun, Apr 28, 2013 at 10:44:38AM -0400, Jamal Hadi Salim wrote:
> commit ba9b18dbcad853e22ea2b8ecf87d53ef2f6cf58c
> Author: Jamal Hadi Salim <jhs@...atatu.com>
> Date:   Sun Apr 28 07:41:47 2013 -0400
> 
>     Detect future iptable changes interfaces earlier in the dev
>     cycles. Hopefully someone is going to complain about such breakage
>     and we'll get the fix in sooner.
>     
>     Signed-off-by: Jamal Hadi Salim <jhs@...atatu.com>
> 
> diff --git a/tc/m_xt.c b/tc/m_xt.c
> index 3edf520..b266337 100644
> --- a/tc/m_xt.c
> +++ b/tc/m_xt.c
> @@ -129,6 +129,10 @@ static int parse_ipt(struct action_util *a,int *argc_p,
>  	__u32 hook = 0, index = 0;
>  	struct option *opts = NULL;
>  
> +#if (XTABLES_VERSION_CODE > 7)
> +#error Someone call the guy who changed xtables ver 7 and \
> +	make him fix it^W^W^W^W say you need help.
> +#endif

BTW, iptables 1.4.19 (that will be released soon) will be
XTABLES_VERSION_CODE == 10:

libxtables_vcurrent=10
libxtables_vage=0

XTABLES_VERSION_CODE = libxtables_vcurrent - libxtables_vage

iptables 1.4.19 -> 10
iptables 1.4.18 -> 10
iptables 1.4.17 -> 9
iptables 1.4.16.3 -> 9
[ seems like we have skip one by accident ]
iptables 1.4.15 -> 7

So this error that Jamal proposes will be hit soon again by users. But
I don't think all those API updates affect xt action though. There is
a limited amount of functions that xt action uses.

Let me think if I can come with a better idea.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html