netdev - Re: [PATCH] sfc: fix return value check in efx_ptp_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1367938273.2782.7.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Tue, 7 May 2013 15:51:13 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
CC:	<linux-net-drivers@...arflare.com>,
	<yongjun_wei@...ndmicro.com.cn>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] sfc: fix return value check in efx_ptp_probe_channel()

On Tue, 2013-05-07 at 20:19 +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> In case of error, the function ptp_clock_register() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
Reviewed-by: Ben Hutchings <bhutchings@...arflare.com>

Although the current code is obviously wrong not to set rc, it was not
clear that ptp_clock_register() returns an ERR_PTR rather than NULL on
error.  Please could you add that fact to its kernel-doc comment?

Ben.

> ---
>  drivers/net/ethernet/sfc/ptp.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
> index 07f6baa..9a95abf 100644
> --- a/drivers/net/ethernet/sfc/ptp.c
> +++ b/drivers/net/ethernet/sfc/ptp.c
> @@ -912,8 +912,10 @@ static int efx_ptp_probe_channel(struct efx_channel *channel)
>  
>  	ptp->phc_clock = ptp_clock_register(&ptp->phc_clock_info,
>  					    &efx->pci_dev->dev);
> -	if (!ptp->phc_clock)
> +	if (IS_ERR(ptp->phc_clock)) {
> +		rc = PTR_ERR(ptp->phc_clock);
>  		goto fail3;
> +	}
>  
>  	INIT_WORK(&ptp->pps_work, efx_ptp_pps_worker);
>  	ptp->pps_workwq = create_singlethread_workqueue("sfc_pps");
> 

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html