netdev - Re: [PATCH 10/36] net: ethernet: calxeda: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5189148E.3040603@calxeda.com>
Date:	Tue, 07 May 2013 09:49:50 -0500
From:	Rob Herring <rob.herring@...xeda.com>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	"'David S. Miller'" <davem@...emloft.net>, netdev@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH 10/36] net: ethernet: calxeda: remove unnecessary platform_set_drvdata()

On 05/06/2013 11:25 PM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

netdev is closed during the merge window except for fixes, so you will
have to resubmit this. But when you do:

Acked-by: Rob Herring <rob.herring@...xeda.com>

> ---
>  drivers/net/ethernet/calxeda/xgmac.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c
> index 4a1f2fa..7cb148c 100644
> --- a/drivers/net/ethernet/calxeda/xgmac.c
> +++ b/drivers/net/ethernet/calxeda/xgmac.c
> @@ -1790,7 +1790,6 @@ err_io:
>  	free_netdev(ndev);
>  err_alloc:
>  	release_mem_region(res->start, resource_size(res));
> -	platform_set_drvdata(pdev, NULL);
>  	return ret;
>  }
>  
> @@ -1813,7 +1812,6 @@ static int xgmac_remove(struct platform_device *pdev)
>  	free_irq(ndev->irq, ndev);
>  	free_irq(priv->pmt_irq, ndev);
>  
> -	platform_set_drvdata(pdev, NULL);
>  	unregister_netdev(ndev);
>  	netif_napi_del(&priv->napi);
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html