netdev - RE: [PATCH net 2/4] be2net: Fix ethtool get drvinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1367940097.2782.8.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Tue, 7 May 2013 16:21:37 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	"Kotur, Somnath" <Somnath.Kotur@...lex.Com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"Purayil, Kalesh" <Kalesh.Purayil@...lex.Com>
Subject: RE: [PATCH net 2/4] be2net: Fix ethtool get drvinfo

On Tue, 2013-05-07 at 06:27 +0000, Kotur, Somnath wrote:
> > Although I documented that as being possible in ethtool.h, that was only
> > because of one particular caller that has since been removed (commit
> > e52ac3398c3d 'net: Use device model to get driver name in
> > skb_gso_segment()').  So unless I missed another case, you could change the
> > documentation.
> > 
> Ben, pls correct me if my understanding is wrong here , but I do see
> one more case where it might have been missed and that 
> Is in the function - is_cnic_dev() in cnic.c , I believe this was the
> case that we were trying to work-around with.

It's called from a netdev notifier, which holds the RTNL lock.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html