netdev - Re: [Patch net] udp: remove a useless initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALnjE+oh7JpDYDn6ju3Pr8Qh_EA-9uEK08G3mUO-z-VLbOxVGw@mail.gmail.com>
Date:	Tue, 7 May 2013 21:17:02 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Cong Wang <amwang@...hat.com>
Cc:	netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net] udp: remove a useless initialization

On Tue, May 7, 2013 at 8:04 PM, Cong Wang <amwang@...hat.com> wrote:
> 'inner_eth' is not used until it is assigned with the same
> value later.
>
since you are at this code, can you also pull inner ether header?

Thanks,
Pravin.
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Pravin B Shelar <pshelar@...ira.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <amwang@...hat.com>
>
> ---
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index 0ae038a..3d036bdd 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -2311,7 +2311,7 @@ static struct sk_buff *skb_udp_tunnel_segment(struct sk_buff *skb,
>         struct sk_buff *segs = ERR_PTR(-EINVAL);
>         int mac_len = skb->mac_len;
>         int tnl_hlen = skb_inner_mac_header(skb) - skb_transport_header(skb);
> -       struct ethhdr *inner_eth = (struct ethhdr *)skb_inner_mac_header(skb);
> +       struct ethhdr *inner_eth;
>         __be16 protocol = skb->protocol;
>         netdev_features_t enc_features;
>         int outer_hlen;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html