netdev - Re: [PATCH] gso: Handle Trans-Ether-Bridging protocol in skb_network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <518A01F9.8090403@linux.intel.com>
Date:	Wed, 08 May 2013 00:42:49 -0700
From:	PJ Waskiewicz <peter.p.waskiewicz.jr@...ux.intel.com>
To:	Pravin B Shelar <pshelar@...ira.com>
CC:	netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>,
	Cong Wang <amwang@...hat.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] gso: Handle Trans-Ether-Bridging protocol in skb_network_protocol()

On 5/7/2013 11:41 PM, Pravin B Shelar wrote:
> Rather than having logic to calculate inner protocol in every
> tunnel gso handler move it to gso code. This simplifies code.

Moving code that isn't used on a regular basis to hotpath for most 
networking to simplify code isn't always a good thing.

Have you run tests on non-tunneled streams using GSO to make sure there 
isn't an adverse impact to performance due to the new, untaken branch?

-PJ
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html