netdev - Re: [PATCH RFC 1/2] net/core: Add netlink directives to control VF link state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <518A76FB.5030704@cogentembedded.com>
Date:	Wed, 08 May 2013 20:02:03 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>
CC:	netdev@...r.kernel.org, amirv@...lanox.com, ronye@...lanox.com
Subject: Re: [PATCH RFC 1/2] net/core: Add netlink directives to control VF
 link state

Hello.

On 08-05-2013 17:45, Or Gerlitz wrote:

> From: Rony Efraim <ronye@...lanox.com>

> Auto -	the VF link state will reflect the PF link state
>
> Enable - VF link stat will be always up, traffic from VF to VF can
> 	 work even if PF link is down.
>
> Disable - VF link state is down and the VF can't send/recv, e.g can be
>    	  used to suspend the link while configuring the VF.

> Signed-off-by: Rony Efraim <ronye@...lanox.com>

[...]

> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index a08bd2b..bec44a3 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1238,6 +1238,15 @@ static int do_setvfinfo(struct net_device *dev, struct nlattr *attr)
>   							       ivs->setting);
>   			break;
>   		}
> +		case IFLA_VF_LINK_STATE: {
> +			struct ifla_vf_link_state *ivl;
> +			ivl = nla_data(vf);

     Why not make it initializer? And empty line is needed between the 
declaration and other code.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html