| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <518AB2D6.1050909@lwfinger.net> Date: Wed, 08 May 2013 15:17:26 -0500 From: Larry Finger <Larry.Finger@...inger.net> To: "H. Peter Anvin" <hpa@...or.com> CC: linux-wireless <linux-wireless@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org>, Dan Williams <dcbw@...hat.com>, 'George0505' <george0505@...ltek.com>, Joon Ro <joonhyoung.ro@...il.com>, Greg KH <gregkh@...ux-foundation.org> Subject: Re: Linux driver for Realtek RTL8723AU devices with USB ID 0bda:1724 such as found in Lenovo IdeaPad Yoga 13 On 05/08/2013 11:29 AM, H. Peter Anvin wrote: > On 05/08/2013 09:06 AM, Larry Finger wrote: >> On 05/07/2013 09:32 PM, H. Peter Anvin wrote: >>> >>> So I can verify that this driver works against 3.8.11 (not against >>> current -linus because of a build failure), and yes, there is Bluetooth >>> in this device. In fact, it seems to work better than some in-tree >>> drivers I have seen in the past. >>> >>> However, I'm confused as to the above and what it implies for the >>> purpose of the staging tree. Wasn't the whole point of the staging tree >>> to have a working-but-ugly driver upstream and have the work to clean it >>> up happen in the mainline tree instead of off somewhere. >> >> Yes, but even staging has some standards. For example, they frown on >> inclusion of firmware in a massive data block in a file in the driver - >> it should be in a separate file the /lib/firmware/ tree. In addition, >> the mainline drivers/net/wireless/ tree is only available to devices >> that use mac80211 for the software-based MAC layer. That conversion is a >> serious effort that may never be done, thus the 8723au driver may never >> leave staging. >> >> What are the details of the build failure on the mainline tree? It >> builds fine here. One possibility is that your source tree has a >> leftover copy of include/linux/version.h that contains a stale coded >> value of the kernel version. I just pushed a Makefile fix that causes >> the compiler to look in the new location for version.h first. If that >> doesn't work, please post the error. >> > > Unlikely, since the kernel source tree is clean. > > The error is on os_dep/os_intfs.c: > > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c: In function ‘rtw_proc_init_one’: > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:315:3: error: implicit declaration > of function ‘create_proc_entry’ [-Werror=implicit-function-declaration] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:315:11: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:322:3: error: implicit declaration > of function ‘create_proc_read_entry’ [-Werror=implicit-function-declaration] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:322:9: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:333:21: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:364:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:370:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:372:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:378:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:381:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:389:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:397:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:405:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:412:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:419:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:426:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:433:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:440:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:447:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:454:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:461:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:468:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:475:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:482:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:489:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:496:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:505:9: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:512:9: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:522:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:539:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:545:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:547:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:553:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:555:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:561:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:563:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:569:7: error: dereferencing pointer > to incomplete type > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:572:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:576:8: warning: assignment makes > pointer from integer without a cast [enabled by default] > /home/hpa/kernel/rtl8723au/os_dep/os_intfs.c:582:7: error: dereferencing pointer > to incomplete type I just pushed a "fix" that will allow the driver to build on kernel 3.10-rc0 (aka 3.9-git). This one removes all the procfs stuff. It will be added back in /sysfs later. Larry -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists