netdev - Re: [Patch net-next v3 2/3] bridge: only expire the mdb entry when query is received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130509051522.GA7998@gondor.apana.org.au>
Date:	Thu, 9 May 2013 13:15:22 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Cong Wang <amwang@...hat.com>
Cc:	netdev@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	"David S. Miller" <davem@...emloft.net>,
	Adam Baker <linux@...er-net.org.uk>
Subject: Re: [Patch net-next v3 2/3] bridge: only expire the mdb entry when
 query is received

On Mon, May 06, 2013 at 11:24:13AM +0800, Cong Wang wrote:
> On Fri, 2013-05-03 at 17:30 +0800, Herbert Xu wrote:
> > On Fri, May 03, 2013 at 03:08:46PM +0800, Cong Wang wrote:
> > > On Fri, 2013-05-03 at 12:01 +0800, Herbert Xu wrote:
> > > > 
> > > > I think I quoted the wrong hunk in the patch, I meant the code
> > > > that arms the timer should no longer be in the leave_group function
> > > > unless we just sent a query ourselves (and in that case the expiration
> > > > should also be adjusted accordingly).
> > > 
> > > Is the following patch what you meant?
> > 
> > Right, but also add the corresponding timers in case we send a
> > group-specific query since that won't loop back to ourselves.
> 
> Ok, then something like below , it is a delta patch, the first piece
> should go to patch 3/3.

Yes this looks about right.  BTW, for the groups-epcific queries
you should use the leave timeout values and not the startup timeout
values.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html