netdev - Re: [PATCH RFC iproute2] Add VF link state control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZ+bHAOH-TMGaosZHZ8ibKQRGN1BLkJbM1r203UmSytSig@mail.gmail.com>
Date:	Thu, 9 May 2013 11:34:47 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	John Fastabend <john.r.fastabend@...el.com>,
	"Rose, Gregory V" <gregory.v.rose@...el.com>,
	Alexander Duyck <alexander.h.duyck@...el.com>
Cc:	netdev@...r.kernel.org, Rony Efraim <ronye@...lanox.com>,
	Amir Vadai <amirv@...lanox.com>
Subject: Re: [PATCH RFC iproute2] Add VF link state control

> John Fastabend <john.r.fastabend@...el.com> wrote:
> > It does seem unfortunate though that every time we want a feature that
> > already exists to be applicable for a VF we have to go through this
> > exercise of adding an ndo op and adding lookup code in each and
> > every driver to find the VF and pass messages back and forth.
>
> agree, how about introducing ndo_set_vf_config which we can extend to
> include new attrbiutes each time we want to add them...  actually do
> we have robust way to extend the existing ifla_vf_info? I guess so
>
> int (*ndo_get_vf_config)(struct net_device *dev, int vf, struct ifla_vf_info *ivf);

Do we lean towards introducing new call/s to set/get VF config and can
be extended to new features as they come  - e.g
control VF link state, read VF packet/byte counters, set vlan egress
map for the VF when its in VGT mode, etc, or
stick to the current method of one ndo per need?


>
> these two calls are also there but only the enic driver uses them
>
> int (*ndo_set_vf_port)(struct net_device *dev, int vf, struct nlattr *port[]);
> int (*ndo_get_vf_port)(struct net_device *dev, int vf, struct sk_buff *skb);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html